clippy: fix needless_pass_by_value lint#2205
Open
xtqqczze wants to merge 1 commit intopendulum-project:mainfrom
Open
clippy: fix needless_pass_by_value lint#2205xtqqczze wants to merge 1 commit intopendulum-project:mainfrom
xtqqczze wants to merge 1 commit intopendulum-project:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2205 +/- ##
==========================================
- Coverage 83.71% 83.52% -0.20%
==========================================
Files 93 93
Lines 21640 21642 +2
==========================================
- Hits 18117 18076 -41
- Misses 3523 3566 +43
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Feel free to ignore the ci failure, that is unrelated to your PR. |
This comment was marked as resolved.
This comment was marked as resolved.
xtqqczze
force-pushed
the
clippy/needless_pass_by_value
branch
from
9d6dfa6 to
9bd8e36
Compare
davidv1992
requested changes
Apr 16, 2026
Member
davidv1992
left a comment
davidv1992
left a comment
There was a problem hiding this comment.
Thank you, mostly looks good, just a few minor things about references to PathBufs:
xtqqczze
force-pushed
the
clippy/needless_pass_by_value
branch
2 times, most recently
from
a2b3041 to
ed0682a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
xtqqczze
force-pushed
the
clippy/needless_pass_by_value
branch
from
ed0682a to
ab52a02
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://rust-lang.github.io/rust-clippy/master/#needless_pass_by_value